fix: update, delete, accept, decline all occurrences - #7600

Codecov Report

❌ Patch coverage is 79.01786% with 47 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

Hi,
Any news about this development's progression ?
I think that this development is actually important for web UI end-users.
Thanks !

Hello,

that's a big problem for us too. It would be great if that could be fixed soon.
Thanks

@SebastianKrupinski ; may this PR resolve #6146 as well ?

@SebastianKrupinski ; may this PR resolve #6146 as well ?

That is the idea, I just need to figure out the best work flow logic.

PHP errors are unrelated

/backport to stable6.6

@odzhychko should be good now

@odzhychko Do you mind giving this one last test!?

Manual test — recurring event save/delete scopes

Setup: create one non-recurring event, and one recurring event (e.g. weekly, 5+ occurrences) with no exceptions yet, in a writable calendar.

Non-recurring events

• Create a new event, save it — appears correctly on the grid.
• Edit title/time/location on an existing non-recurring event, save — updates correctly.
• Delete a non-recurring event — the single event disappears.
• Move a non-recurring event to a different calendar — moves without duplicating.

Recurring series — editing the first/primary occurrence

• Open the first occurrence, change a non-date property (e.g. location), save with "This and all occurrences" / series — change applies to the whole series.
• Open the first occurrence, change the date/time, save as series — the whole series shifts accordingly (no warning shown).
• Open the first occurrence — confirm only "series" is offered for both update and delete (no "this occurrence" / "this and future" options).
• Delete the first occurrence with series scope — the entire series is deleted.
• Move the first occurrence to another calendar (series scope) — whole series moves, no duplicates left behind.

Recurring series — editing an nth (non-primary) occurrence

• Open a middle occurrence, change a non-date property, save as series — property applies to the whole series; occurrence's own date/time is untouched.
• Open a middle occurrence, change the date/time, save as series — a warning appears saying the date/time change was discarded; series keeps its original schedule; the editor itself shows the reverted (unchanged) time, not the discarded one.
• Open a middle occurrence, change a property, save as "this occurrence" — only that single occurrence changes; the rest of the series is untouched; grid shows the change only on that date.
• Open a middle occurrence, change a property, save as "this and future occurrences" — the original series is truncated (ends the day before), and a new separate series starts from that occurrence onward with the change applied.
• Delete a middle occurrence with "this occurrence" — only that date disappears, rest of series remains.
• Delete a middle occurrence with "this and future" — that occurrence and everything after it disappears, earlier occurrences remain.
• Delete a middle occurrence with series — entire series is deleted.

Existing recurrence exceptions (an occurrence already moved/edited once)

• Create an exception first (edit one occurrence with "this occurrence" scope, changing its date/time so it's visually distinct).
• Re-open that exception — confirm only "this occurrence" is offered for both update and delete (no "series" / "this and future").
• Edit the exception again (e.g. title) and save — updates just that exception, rest of series untouched.
• Delete the exception — only that single occurrence is removed; the rest of the series (and the series itself) remains intact. (This was the bug we just fixed — worth double-checking carefully.)

Edge cases

• All-day recurring event: edit a non-primary occurrence's date, save as series — discard warning behaves the same as a timed event, no crash.
• Recurring event whose start date doesn't align with its own BYDAY rule (e.g. weekly-Monday rule but DTSTART on a Thursday) — first occurrence is still correctly treated as "primary" for the series-only restriction.
• Change only the timezone (not the actual time) on a non-primary occurrence, save as series — still triggers the discard warning.
• Toggle an occurrence to/from all-day only (same start instant), save as series — still triggers the discard warning.